Michal Čihař - Blog Archives for phpMyAdmin

Last week I've finally got to common.inc.php cleanup which is assigned to me for more than year. I've again managed to cleanup some parts of it, but it's quite challenging task as whenever I touch this (mostly ancient) code, I found some issues with it and have to fix other things as well.

Another interesting topic was fixing operation with database or table called 0. This is well known PHP issue that empty function in string containing just 0 will return true, however some of our code was using that to test whether database or table are set. This should be now fixed in master branch.

Handled issues:

• #13718 Move server selection to Config class
• #13699 Using empty() to check for a set db
• #13403 on 4.7.1, exporting of a whole database to SQL doesn't output the sql, outputs the html.
• #13543 Cannot log in to the MySQL server
• #13552 Not working transformation Ip To Binary
• #13477 Input transformations can't be set
• #13688 http login blank page
• #13709 PMA does not detect real server character set
• #13710 Internal Server Error with Advisor
• #13711 Database Structure view is very slow as of version 4
• #13717 Simplify Template API
• #13715 Creating an easy option for accesing past queries/ History
• #13716 Added FullText #13303
• #13303 Can't create fulltext index on multiple columns

Last week was mostly focused on catching up after two weeks of vacation. That involved quite a lot of things in our issue tracker and cleanup of pending things in pull requests.

Handled issues:

• #13683 Cannot edit blob fields
• #13678 Unexpected 'print' in index.php on line 97
• #13630 Fix error on signon login, need create a cookie with sessionID
• #13560 Change all table collations
• #13682 Added change all table collations when changing database collation
• #13670 Fix edit index field size bug
• #13515 Edit Index field size
• #13687 Adding a column to a table leads to logout
• #13547 Add hhvm 3.21 to test matrix
• #13539 Parameter binding syntax gives error in the SQL editor
• #173 Fix #172 Support parameter binding

Last week was heavily focused on our Selenium tests and improving their speed and reliability. This was pretty much achieved and there seem to be no random failures now.

Handled issues:

• #13659 Attempt to optimize Selenium tests
• #13664 Change password shown behind navigation #13662
• #13657 Use nginx for running Selenium tests
• #13656 Various cleanups in DBI
• #13650 Rewrite forms management to objects
• #13648 Make hash extension required
• #13645 Pagination and Export Issue 4.7.0 & 4.7.4
• #13647 import of table with virtual col (exported with phpMyAdmin) is impossible
• #13380 RFC: Add configuration for Probot Stale
• #13646 Refactor config descriptions
• #13183 Keep Alive Error?
• #13533 "Choose column to display" does not work
• #13638 Notice when browsing IS
• #13632 gitgnore ".github" folder
• #13604 Error when browsing table
• #13637 Warning on invalid metadata from MySQL
• #13639 Notice: Undefined index: statement
• #13640 Notice: Undefined index: querytype
• #13611 Twig introduces ctype dependecy
• #13633 Some elements are not translated directly after changing language
• #13629 Saving diagram fails
• #13635 Designer cannot save page
• #13619 Solved issue #13617
• #13617 Unnecessary data should not come in clipboard copied table
• #169 UNTIL keyword

Last week was pretty productive on bug fixing side. These were quite varied from server monitor breakage on non Linux and Windows platforms to minor rendering issues of date selector. Quite interesting new feature is that our SQL parser now better understands to some MariaDB extensions.

Handled issues:

• #13444 JavaScript error in Status Monitor on FreeBSD server
• #13353 phpmyadmin search size large database not work
• #13500 recaptcha fails
• #13628 TypeError in server monitor
• #13158 Please enter a valid length!
• #13267 Database with dot (.) in name is not shown when DisableIS is set to true
• #13336 Phpmyadmin "Show binary contents as HEX" missing
• #13347 Missing values on modifying fields with CURRENT_TIME default and 'on update CURRENT_TIME()' attribute
• #13620 Update openid.php
• #13516 Adjust subdomains at url.php
• #13556 500 error on opening setup. Globals[dbi] is missing
• #13576 In "user(s) having access to database" table "Action" column is blank
• #13603 Run Selenium tests on pull requests
• #13612 Calender blocked by hint
• #13615 Error when executing query with WITH clause
• #166 MariaDB: INTERSECT and EXCEPT keywords
• #4 Define multiple contexts

Last week was again mostly spent on fixing bugs and going through reports on our error reporting server. This is really valuable tool for finding problems which hit our users, on the other side there is simply too many things there and sometimes it's hard to pinpoint something really important.

Besides that I've also ensured that all our libraries work well with upcoming PHP 7.2 and all are now tested on Travis CI against this version as well.

Handled issues:

• #13606 Clicking "Refresh" on "All status variables" page yields a "Token mismatch" error
• #13605 Minor refactoring in Selenium tests
• #13601 Connecting to Azure MySQL database
• #13597 Fix #13593 : removed whitespace in textarea for column default value
• #13599 Warning on using debug_backtrace
• #13600 Warning on failure during export
• #12791 Warning on creating unknown context
• #13595 ALTER TABLE parser error
• #13594 Fix random selenium failure tests
• #13593 Default value field contains whitespace
• #13590 #13512 Patch
• #13512 Add inde issue

Last week was a bit less intensive on bug fixes, but I've spent quite a lot of time on improving our localized documentation and fixing various errors there. This is really something what should be automatically checked in Weblate in the long term, but right now it results in build failures in Travis.

Handled issues:

• #13553 fix error in table
• #13568 Setup script message "Show hidden messages (#MSG_COUNT)"
• #13588 Add QBE tests
• #13585 show error message on export page when database is empty

I've spent last week on DebConf, where main motivation to come was to meet with other phpMyAdmin team members. Besides that we've met with Marc, former phpMyAdmin lead.

On the coding side, it was pretty much just reviewing pull requests and some minor fixes.

Handled issues:

• #13583 Add selenium tests for typing and executing SQL query
• #13571 fix issue #13538
• #13537 type decimal length/values 2nd can't be set
• #13538 "No user selected" warning should come, selecting "Export" button without selecting any checkbox again user in "User Accounts" tab
• #134 alpine+lighttpd+php7-fpm does not work.
• #67 Add a page for the contract developer position
• #65 empty box space in screenshots
• #163 INSERT .. (SELECT ...) fails due to parenthesis

This week was quite productive in terms of bug fixes and various code improvements. One of most visible things is probably PHP 7.2 compatibility, but there were other fixes as well.

I've somehow failed to post this report on time, so sorry for late publishing.

Handled issues:

• #13570 Fixes fatal error during setup #13564
• #13561 Server Status Advisor - Variable edit throws a 404
• #13563 maximum length limitation to UserGroup name
• #13567 Fixed tracking report: cannot delete a statement
• #13562 Add maximum length limitation to UserGroup name
• #13555 Charset page's table heading patch
• #13558 Feature suggestion: server alias
• #13554 Table heading of "Charsets" page is not looking right.
• #13545 CodeMirror integration broken
• #13546 Data going out of table in "Variables" page
• #13549 server variables out of table fixed
• #13550 "Copy to clipboard" adds blank lines before data
• #13529 Fields of bit type are always displayed as 1111111111111111111111111111111
• #13408 No warning shown when data out of range altering a table
• #13509 Decimal(12,4) gives Decimal(12,0) result
• #13522 Date Format Browser display transformations no longer working
• #13548 Use runkit7 while testing PHP 7 on Travis
• #13414 PHP 7.2 compatibility
• #13531 Alphabetic sorting of Export dropdown
• #13540 phpmyadmin configuration storage not working
• #13523 Commit should be on own line
• #13544 Sort Import format dropdown
• #13541 Error syntax highlight with this query
• #13425 Sort Export format dropdown
• #13526 Fix Import-related selenium tests
• #13532 Fix unnecessary escaping of html content
• #13535 Merge pull request #1 from phpmyadmin/master

I've made several changes to the Weblate Docker container which are worth mentioning today.

First of all if you are still using nijel/weblate, you should switch to weblate/weblate. They both currently share same configuration, but it might happen that some future updates will go to the weblate owned container only.

Now back to the container changes. Since beginning we were using Django built in server. That's fine for development purposes, but it really doesn't work that well in production as it can handle only one request at time. Therefore we've switched to more robust approach using nginx + uwsgi + supervisor.

Thanks to this, the docker-compose no longer needs separate nginx server as everything is now sanely handled within the weblate container itself.

After fours years, I will again make it to DebConf, I'm looking forward to meet many great people, so if you want to meet and happen to be in Montreal next week come and say hello to me :-).

It seems I've settled down on four year schedule - I've attended DebConf09 and DebConf13 so far. Let's see if next one will come in 2021 or earlier.