Michal Čihař - Archive for Jan. 1, 2017

I got back to work last week after vacation I had. The GSoC selection process is almost done (in two days the accepted students will be announced by Google) and things got again a bit calmer, so the usual amount of bug fixing and pull requests review has been done.

One thing worth mentioning is that we have started to use Twig templates and first templates were just ported to this. It will better enforce logic separation from the templates and also it makes templates easier to read.

Handled issues:

• #13182 Refreshing results results in token mismatch error
• #13207 Port some templates to Twig
• #13195 Remove inline styles from file templates/columns_atributes.phtml #12262
• #13194 Column attribute have a different size
• #13202 Fix:Column attribute have a different size #13194
• #13205 Remove .gitattributes files when creating release
• #13191 Fix designer
• #13209 Drop and Truncate display the database name
• #13140 Feature Request - Drop and Empty should display Database name prominently.
• #13211 <input></input\> -> <input />
• #12301 Multiple Tabs, Database connections (auth_type cookie) : Error Token Mismatch
• #13212 Create an autoload.php in the root directory and tell libraries/common.inc.php to require it
• #13206 Token mismatch on query result export
• #117 Remove VOLUME dockerfile instruction
• #120 Increase default gateway timeout

Last week was a bit shorter for me due to Easter, but still quite some work has been done. My time was mostly was spent on Docker and handling pull requests.

Anyway you won't see my report next week as I'm having few days off.

Handled issues:

• #13104 Adds error if target db has the same name as current db #13099
• #13099 Change default database name in Operations > Copy database to
• #13156 Quick-Search for tables only search in first page
• #13179 Small issue with Dutch translation
• #13180 Fix some coding standard errors in DocBlocks
• #13165 add item in Last-translator
• #13112 Improved database search to allow search for exact phrase match
• #13168 Ignore coding standard errors in transformations plugins classes
• #12388 Database seach not working in some cases
• #13128 Transformations plugin classes doesn't follow PSR-1 class names rule
• #13174 Replaced deprecated jQuery calls.
• #118 You should upgrade to MySQL 5.5.0 or later error
• #114 Environment Variables Is Not Working
• #149 Fixes wrong extract of string tokens with escaped characters.

Weblate 2.13.1 has been released quickly after 2.13. It fixes few minor issues and possible upgrade problem.

Full list of changes:

• Fixed listing of managed projects in profile.
• Fixed migration issue where some permissions were missing.
• Fixed listing of current file format in translation download.
• Return HTTP 404 when trying to access project where user lacks privileges.

If you are upgrading from older version, please follow our upgrading instructions.

You can find more information about Weblate on https://weblate.org, the code is hosted on Github. If you are curious how it looks, you can try it out on demo server. You can login there with demo account using demo password or register your own user. Weblate is also being used on https://hosted.weblate.org/ as official translating service for phpMyAdmin, OsmAnd, Aptoide, FreedomBox, Weblate itself and many other projects.

Should you be looking for hosting of translations for your project, I'm happy to host them for you or help with setting it up on your infrastructure.

Further development of Weblate would not be possible without people providing donations, thanks to everybody who have helped so far! The roadmap for next release is just being prepared, you can influence this by expressing support for individual issues either by comments or by providing bounty for them.

Weblate 2.13 has been released today pretty much on the schedule. The most important change being more fine grained access control and some smaller UI improvements. There are other new features and bug fixes as well.

Full list of changes:

• Fixed quality checks on translation templates.
• Added quality check to trigger on losing translation.
• Add option to view pending suggestions from user.
• Add option to automatically build component lists.
• Default dashboard for unauthenticated users can be configured.
• Add option to browse 25 random strings for review.
• History now indicates string change.
• Better error reporting when adding new translation.
• Added per language search within project.
• Group ACLs can now be limited to certain permissions.
• The per project ALCs are now implemented using Group ACL.
• Added more fine grained privileges control.
• Various minor UI improvements.

If you are upgrading from older version, please follow our upgrading instructions.

You can find more information about Weblate on https://weblate.org, the code is hosted on Github. If you are curious how it looks, you can try it out on demo server. You can login there with demo account using demo password or register your own user. Weblate is also being used on https://hosted.weblate.org/ as official translating service for phpMyAdmin, OsmAnd, Aptoide, FreedomBox, Weblate itself and many other projects.

Should you be looking for hosting of translations for your project, I'm happy to host them for you or help with setting it up on your infrastructure.

Further development of Weblate would not be possible without people providing donations, thanks to everybody who have helped so far! The roadmap for next release is just being prepared, you can influence this by expressing support for individual issues either by comments or by providing bounty for them.

It's hard for me to pinpoint something from last week - it had usual amount of fixes, pull requests on both phpMyAdmin, Docker image and SQL parser.

Overall I feel we've already piled up quite a lot of fixes over 4.7.0, maybe it's time to reconsider the two monthly schedule, to push the fixes more frequent to users. I'm really unsure how to balance the release schedule. With one month cycle, the releases seem to come too frequently, but with two months, there are quite a lot of fixes in the release which probably could have been released earlier...

Handled issues:

• #13143 PPA requires php7.1-mysql despite php7.0-mysql being installed
• #13141 CREATE ... SELECT
• #13161 fix typo
• #13157 Fix: PHP Fatal error: Uncaught Error: Call to a member function isAjax() on null
• #13154 PHP Fatal error: Uncaught Error: Call to a member function isAjax() on null
• #13100 Initial support for Twig template engine
• #11717 Inline comments striped from stored procedure.... on import
• #13139 Inline comments making succeeding line commented - new line removed
• #13152 Unable to show data if draggable column's HTML is changed.
• #13153 Token mismatch error.
• #13148 Fixed everlasting loading of ajax progress bar
• #13130 Improve AJAX error handling
• #13144 New in DB dropdown
• #13137 Is it problematic to make ownership, grouping, and permissions of phpmyadmin as of website dirs?
• #13146 Releases contain require-dev packages
• #13149 Remove root-relative links from changelog.php
• #13150 Error: Token mismatch when changing the page using the combobox
• #13138 Fix: #13131 - Right-align decimal values
• #13131 Right-align decimal values
• #13134 Add object-src 'none' to Content Security Policy header
• #13142 English improvements and typo fixes
• #112 PMA_PORTS variable ?
• #116 Update config.inc.php
• #113 Please update "latest" to 4.7.0
• #146 Fixes striping of inline comments #11717
• #147 Fixes importing inline comments #13139

Hosted Weblate provides also free hosting for free software projects. Finally I got to processing requests a bit faster, so there are just few new projects.

This time, the newly hosted projects include:

• Pext - Python-based extendable tool
• Dino - modern Jabber/XMPP Client using GTK+/Vala

If you want to support this effort, please donate to Weblate, especially recurring donations are welcome to make this service alive. You can do them on Liberapay or Bountysource.

Last week before GSoC applications deadline is over and we will start evaluating student proposals now. As usual, many students are coming to the project in last minute and start asking basic questions few days or hours prior to deadline. This period is now over and we can again more focus on fixing bugs and guiding contributors.

I've spent quite a lot of time on our Docker container last week, mostly to improve it's testing - it's now possible to execute tests from within the container as well, there is also separate Docker compose configuration to run tests.

Handled issues:

• #13133 Broken links in setup
• #13083 stable/master setup disabled in demo.phpmyadmin.net
• #13125 Return focus to textarea after inserting column name
• #13126 Fix: Focus back to codemirror editor on selecting column
• #13132 4.7.0 using logged in user to access pma__tracking table.
• #13122 Go button not clicked due to not being in view
• #13121 Fix some coding standard errors
• #111 Improve testing image
• #110 Update docker-compose test environment based on CI's tests
• #145 Fix parsing of DELETE clauses with JOINs

Few months ago, I've written about getting coverage information from many platforms into one report. That approach worked, but I've always felt guilty for pushing almost thousand of files to Codecov.

This week I finally found time to revisit this and make it work better and faster. Actually just uploading these files took about 30 minutes. Together with slow tests execution (which took about 30 minutes as well), we were reaching AppVeyor build time limits and builds did timeout quite often, what is not really nice result.

I've started with rewriting the wrapper used to execute OpenCppCoverage. I've originally used Python for that, which is nice, but I thought the overhead must be noticeable. As it is not possible to execute Python script directly from CTest, it was wrapped in simple bat file, adding another overhead. Reimplementing this in C showed that there is indeed overhead, but this is not going to save more time than few minutes.

Next obvious step was to look at uploading coverage files as this is really something what should be fast and not take such enormous time. When writing the original post, I've already tried to merge coverage data using OpenCppCoverage, but that showed to be too slow to make it actually work (the testsuite didn't complete in given 60 minutes).

I was also looking at existing solutions to merge Cobertura XML files, but I've found nothing working reasonably fast. The problem is that all of these always merge two files at one step, making merging thousand files really slow job as you're constantly generating, parsing and processing the resulting xml file for 1000 times. Also these solutions are probably more generic that what I needed.

In the end these files are just simple XML and merging them should not be hard. I was able to quickly write Python script to merge them. It does not support all of the Cobertura attributes, it just merges line based coverage (as this is the only thing which OpenCppCoverage generates), but works pretty fast and reliable.

Overall the build time went down from 60 minutes to 35 minutes and I don't see much space to improve besides improving OpenCppCoverage speed, what is really out of scope for me. Actually older version (0.9.5.3) performs way faster than current one (0.9.6), which is 2-3 times slower.

Yesterday Gammu 1.38.2 has been released. This is bugfix release fixing for example USSD or MMS decoding in some situations.

The Windows binaries are available as well. These are built using AppVeyor and will help bring Windows users back to latest versions.

Full list of changes and new features can be found on Gammu 1.38.2 release page.

Would you like to see more features in Gammu? You an support further Gammu development at Bountysource salt or by direct donation.

Last week was again quite busy with reviewing pull requests from GSoC applicants and going through incoming bugs for 4.7.0-rc1 as we're approaching final 4.7.0 which should be released this week.

I've finally spent some time on our documentation and it got branch new chapter Security policy. It's content is mostly from old wiki, but has been updated with current information. It's still not covering all topics, but at least we have some foundation to base on.

Handled issues:

• #13117 Errors on replication page of master (Warning in ./libraries/dbi/DBIMysqli.class.php#298)
• #13116 Fix coding standard errors using vendor/bin/phpcbf
• #13060 Implement PSR-11
• #13110 Cannot connect with PMA > 4.6.0
• #13115 Encrypt passwords in .travis.yml
• #13114 POST request to navigation.php?ajax_request=1 returns HTML
• #13103 Adds non-conflicting default new database name #13099
• #13091 Class 'PMA\libraries\Util' not found in /www/phpMyAdmin/libraries/sanitizing.lib.php
• #13111 Is there any chance to add an anti-BFA mechanism?
• #12349 Undefined variable: result in import area
• #13109 Solving-Undefined variable: result in import area #12349
• #12757 Error when creating new user on MariaDB 5.5.53
• #13098 Fix database search with newer php-gettext
• #13108 I can't connect to my phpmyadmin
• #12567 Remove ./libraries/tbl_info.inc.php by moving it's code to Table class
• #12931 Tabl info.inc.php moved to table class #12567
• #13105 Unable to change attribute to UNSIGNED for am INT VIRTUAL column
• #13107 Fixes adding attribute while updating virtual col #13105
• #13092 "Error in processing request" red box on start.
• #60 missing credit in PMASA-2017-5 in References
• #59 Replace SHA1 checksums as they 'practically' broken
• #58 Mention hardening label in security page